When computing package initialization order, special case the counter
variables inserted by "cmd...

Replace all uses of Ctz64/32/8 with TrailingZeros64/32/8, because they
are the same and maybe du...

CL 428157 and CL 428759 switched debuglog to using unsafe.String and
unsafe.Slice, which broke t...

This sets up for delaying the decision of which seed to use,
but this CL still keeps the origina...

The immediate reason is that we want to use godebug from math/rand,
and math/rand importing gode...

UnsafePointer.Store, UnsafePointer.CompareAndSwap were missing,
although .StoreNoWB and .Compare...

Change-Id: I77c61211a488c66f1d445c0bf01e35aaf4f83565
GitHub-Last-Rev: c411a56a3b5215e6dd093be706...

Fixes longtest builders.

Change-Id: I8b375bcfc91695d5810493b972801df82c6c1b7c
Reviewed-on: http...

Previously we used Go 1.17, but we realized thanks to tickling
a pre-Go1.17.3 bug that if we are...

The only purpose of using the SHA256 in the file name is
collision avoidance. Using just the fir...

Change-Id: I9b18b29e14a47765dc09ac401989e0439fbf7d03
GitHub-Last-Rev: 7d9792ccb97f8e20bc5300cb4f...

Add more skips if short mode testing, since some of these tests
still seem to be timing out on s...

The src.NoXPos in fake receivers was leaking, through a series of
mishaps, all the way to logopt...

Fixes #56233

Change-Id: I1cf176bc2f39c5e41d5a390ec6893426cdd39be0
Reviewed-on: https://go-revie...

Currently, the entry-point to this test is a Bash script that smoke
tests the FORTRAN compiler a...

This test was originally Linux-only, but there doesn't seem to be
anything Linux-specific in it....

Currently, TestCgoSigfwd will pass incorrectly if the SIGSEGV that
originates in Go mistakenly g...

This migrates testsigfwd, which uses some one-off build
infrastructure, to be part of the runtim...

This code was introduced in CL 17903 but has never executed. It's also
fundamentally non-determi...

This can reduce a bunch of rules.

Change-Id: Id7d644307c295a0ed16eb837b3755d1117a4fbf7
Reviewed...

On newer amd64 cpus 3 operand LEA instructions are slow, CL 114655 split
them to 2 LEA instructi...

Assuming the two values are valid and non-comparable, Equal should panic.

x := reflect.ValueOf...

Remove a vestigial " // BUG" comment as there is no bug in the relevant code section and comment...

Change-Id: I171905d5cd7a121de549827ef4d5968510aa3efc
Reviewed-on: https://go-review.googlesource...

This appears to have been left over from a C cast during the rewrite of
malloc into Go in https:...

The Grow method is like the proposed slices.Grow function
in that it ensures that the slice has ...

For #37329.
For #56233.

Change-Id: Iafcddaddafd2d27fa5d535b57aaefec387f0b3f0
Reviewed-on: https...

The testasan test was added back in 2013 (CL 10126044), many years
before Go added ASAN support ...

Should fix the mayMoreStack test.

Change-Id: Iab99192629ab62ced81e95d756f2dd15f9b7e869
Reviewed...

We haven't used this in a while and it's going to complicate later
changes to dist, so drop supp...

If no external linker was passed with -extld, link currently assumes
that it is "gcc" which is n...

LLVM recently introduced ZSTD compression for ELF sections. The error
message when failing to re...

We started running this test under HTTP/2 in a recent refactoring.
It seems to be flaky for HTTP...

Fixes #51589

Change-Id: Ie9c56110754f4a435b22e2d7a86ae34b0bd28909
Reviewed-on: https://go-revie...

The existing version of this test contains several races it tries to
control with sleeps. Unfort...

Change-Id: Ic4b2b8ff5c7d7e4d9850e0b5a5b52b09b45816f5
Reviewed-on: https://go-review.googlesource...

Change-Id: I50152fa251e599e2c95f68148aee3c16b222da60
Reviewed-on: https://go-review.googlesource...

Now that we plumb the start line to the runtime, we can include in pprof
files. Since runtime.Fr...

This adds the function "start line number" to runtime._func and
runtime.inlinedCall objects. The...

Adjust os/arch checks to enable msan tests on freebsd/amd64.

R=go1.20

For #53298

Change-Id: I...

Enable -msan flag on freebsd/amd64 and amend PIE comment in
internal/work/init.go to indicate th...

Adjust build constraints and change the runtime to call the C mmap function
when using cgo.

R=g...

Optimised RGBA image encoding to PNG. Improved test coverage. Reworked benchmark.

Performance i...

There are getting to be enough special cases in this wrapper that
the increase in clarity from h...

Write .note signature section when targeting FreeBSD, similar to NetBSD
and OpenBSD. This allows...

Workspaces with a single module would enter mod=vendor mode even when
in workspace mode. Fix tha...

If we use the "pipetest" helper command instead of "sleep",
we can use its stdout pipe to determ...

This will dump more goroutines if the test happens to fail.

For #50138.

Change-Id: Ifae30b5ba8...

The linker's -X flag allows setting/changing a string variable's
content at link time. Currently...

And add a link. Resolves a comment left on http://go.dev/cl/436096
after it was submitted.

Chan...

Adds a package level doc comment to the debug/dwarf, debug/elf,
debug/macho, debug/pe, and debug...

The package doc included the copying header by mistake.

Change-Id: I37ac2d14b1b8a389e6b603fbb1c...

This mode is now always 0. Remove the unnecessary argument to better
align with types2.

Change-...

LookupFieldOrMethod appears as a hotspot when benchmarking gopls'
auto-completion. In particular...

Using importcfg instead of depending on the existence of .a files for
standard library packages ...

No test case because the problem can only happen for invalid data. Let
the fuzzer find cases lik...

Fixes #51025.

Change-Id: I469a705e7da059e7ac0b12b05beb9ed5d3617396
Reviewed-on: https://go-revi...

Since we already provide the error code, the prefix can be deduced
automatically.

Except for th...

Fixes #56150

Change-Id: Id990783562950ba8be7ce9526b7a811625f2190a
Reviewed-on: https://go-revie...

While we're here, replace a couple uses of os.Environ with cmd.Environ.

For #51317.

Change-Id:...

This change adds the arenas package and a function to reflect for
allocating from an arena via r...

This change adds an API to the runtime for arenas. A later CL can
potentially export it as an ex...

This change makes (*mheap).sysAlloc take an explicit list of hints and a
boolean as to whether o...

No-op change in preparation for arenas.

For #51317.

Change-Id: I0777f21763fcd34957b7e709580cf2...

This change refactors span heap initialization. This change should just
be a no-op and just prep...

Dragonfly and FreeBSD both used numerical values for these constants
chosen to be the same as on...

Initializes the R3 register with an available address in the stack. The addressed location is us...

Skip TestTransportPersistConnLeakShortBody in HTTP/2 mode;
it's flaky and was previously HTTP/1-...

Updates #38714

Change-Id: Ie5c7761ec003f84e649fa4c90be184a5ff6a0879
Reviewed-on: https://go-rev...

Delete some unused code, and fix a few warnings from staticcheck.

Change-Id: I3d3a6f13dccffda06...

fakePC uses hash.Sum32, which returns an uint32. However, libfuzzer
trace/hook functions declare...

The errorcalls_test makes sure that we use error instead of errorf
where possible. Copied from t...

Checker.errorf calls now have an error code and thus require at
least 4 arguments.

Change-Id: I...

This brings go/types error reporting closer to types2.

Except for removing the error functions ...

When running go install --mod=readonly module@version. modfetch.GoSumFile
was not set, so the ch...

Fixes #56156

Change-Id: Ib85ff45f0b0d0eac83c39606ee20b3a312e6e919
Reviewed-on: https://go-revie...

go list -e -export puts errors running build actions on the load.Package
corresponding to the fa...

Change-Id: I0c8823b9c3c12f0f581b24db6a7aa5a0cd913224
Reviewed-on: https://go-review.googlesource...

As of CL 438347, multiple concurrents calls to Close should be safe.

This removes some indirect...

Delete some unused code, various cleanups to fix staticcheck warnings.

Change-Id: Ie475d57735a8...

Fold negation into subtraction and avoid double negation.

This removes around 500 instructions ...

Convert SLT/SLTU with a suitably valued constant into a SLTI/SLTIU instruction.
This can reduce ...

Combine masking with a negative value and zero extension into a single
AND operation.

Change-Id...

For #56109

Change-Id: I999763e463fac57732a92f5e396f8fa8c35bd2e1
Reviewed-on: https://go-review....

CL 403995 fixed static init of literal contains dynamic exprs, by
ensuring their init are ordere...

Mark the "l1" and "l2" methods on "arenaIdx" with //go:nosplit, since
these methods are called f...

This patch fixes up a bug in the inliner's special case code for
coverage counter updates, which...

This change modifies 'go version' to support shared windows libraries.

Updates #48187

Change-I...

Use InvalidSyntaxError where the zero error code was used before.
Fix a couple of places that di...

Type checkers should use InvalidSyntaxTree as error code
for invalid syntax tree errors instead ...

Change-Id: If9b5c2c5d1b89146250bcd19965797baab315876
Reviewed-on: https://go-review.googlesource...

This change adds a new dependency to go/types.

Change-Id: I7e40b95c8c1e1356b638fc1aa2ef16ce91e9...

This avoids a conflict when dot-importing this package in
go/types and types2.

Change-Id: Ia6fc...

Adjust self-test accordingly.

Change-Id: I69987a306760da9eaf832275af0e9a8b6131a349
Reviewed-on:...

The internal/types/errors package defines all error codes used by
the type checkers. This is the...

If a generic type declaration is missing a constraint, syntactically
it is an array type declara...

Add "-O2" to all compiler/linker tests. This makes compiler/linker
feature probing better resemb...

Run "go build ./x" in this workspace:

-- go.work --
use ./y
-- x/go.mod --
module x

...

This permits us to safely support concurrent access to files on Plan 9.
Concurrent access was al...

This is a follow up of CL 393656 on arm64.

This CL puts ScoreCarryChainTail before ScoreMemory ...