Though we split traces into 100MB chunks, currently each chunk always
includes the entire stack ...

runtime.bgsweep contains an infinite loop. With aggressive enough
inlining, it may not perform a...

For #47257

Change-Id: I3837220d02741da92d723484c82d11e82c92151a
Reviewed-on: https://go-review....

ISEL is roughly equivalent to CMOV on PPC64. Verify ISEL generation
in all reasonable cases.

No...

Updates #31884

Change-Id: Ibad3d31038a8426c0bce61c1726392880f934865
Reviewed-on: https://go-rev...

Change-Id: I1f713bbb35917ab50b0cde24a81340aa16c2ed03
Reviewed-on: https://go-review.googlesource...

Change-Id: Ic16824482142d4de4d0b949459e36505ee944ff7
Reviewed-on: https://go-review.googlesource...

For #46746

Change-Id: I75ddb9ce24cd3394186562dae156fef9fe2d55d3
Reviewed-on: https://go-review....

Change-Id: I871a747b4b47bccc889f2fdc93a2bcebb041b719
Reviewed-on: https://go-review.googlesource...

Currently locations are stored in a map and looked up by ID from
the map. The IDs are usually sm...

Now that most GOROOT packages do not have install targets, their
staleness depends on whether th...

Rather than matching calls to edges in the profile based directly on
line number in the source f...

When adding weights for a call stack, for recursive calls, to
avoid double counting we check if ...

Now that misc/cgo/test doesn't invoke any Go builds itself, we don't
need to use GOFLAGS to thre...

When we were first introducing module mode, CL 163418 moved many of
the tests in misc/cgo/test i...

Currently in the pprof Graph, a Node's in/out edges are
represented as maps, keyed by the source...

We intentionally don't use file path so it is resilient to code
moving. OrigName and Objfile are...

We don't use it. Make graph building a little faster.

Change-Id: I4a6f516f8e68bf338be8350f91c51...

Default concurrency is now GOMAXPROCS, though this is normally
reduced to 4 by the go build comm...

Semicolon has bad copy-paste ergonomics; it requires quoting.
Slash is okay, and won't be a sepa...

With CL 447015, we identify hot callees from edge weights, but
the code only traverses edges for...

This may fix the TestEINTR failures that have been frequent on the
riscv64 builders since CL 445...

Fixes #54794

Change-Id: I6f2b7b86b82ea27b9d53cf989daa21cb8ace13da
Reviewed-on: https://go-revie...

Change-Id: I9bcaba0ca9c30b204bf126dbfec4cd48d9ebe2ea
Reviewed-on: https://go-review.googlesource...

Fixes a bug that was introduced in CL 410414; in that CL, to avoid
a race condition in the initi...

Fixes #55301

Change-Id: Ie8abcd383eee9af75038bde908ac638f43d33b7e
Reviewed-on: https://go-revie...

Plan 9 uses NUL as os.PathListSeparator, so it's almost always going
to appear in the environmen...

The automatic resultInArg0 register check has been implemented by CL 296010.

Change-Id: Id0e085...

There is existing code that calls flag.Lookup("test.v") and inspects
the value. That stopped wor...

Handle emitting (to ld) or resolving commonly used ELFv2 1.5
relocations. The new ISA provides P...

Prior to Go 1.18, ineffectual //go:linkname directives (i.e.,
directives referring to an undecla...

fmt.Sprint should be called instead of fmt.Sprintf as is done
elsewhere in exec.go

Change-Id: I...

This needs to be as low as possible while not breaking priority
assumptions of other scores to c...

This reverts CL 447335.

Reason for revert: broke test on solaris-amd64-oraclerel, which does ha...

go/build attempts to parse comments at the beginning of non-Go files
looking for //go:build or /...

Benchmarking suggests about a 14-17% reduction in user build time,
about 3.5-7.8% reduction for ...

Fixes #56542

Change-Id: I294856f8fb4d49393310ec92ab40fb7d841b6570
GitHub-Last-Rev: a4563400af81...

The stack pointer must lie within system stack limits
when Control Flow Guard (CFG) is enabled o...

In following with Roland's TODO, switch TestDisableSHA1ForCertOnly to ParseRevocationList(...) o...

This adds a -d debug flag "fmahash" for hashcode search for
floating point architecture-dependen...

On some platforms, building PIE needs external linking, which
cannot run if cgo is not available...

Currently in PGO we use a percentage threshold to determine if a
callsite is hot. This CL uses a...

Adding PCALIGN to addMulVVW assembler implementation
provides the following improvement on power...

`TestScripts/svn` test suite fails if the host does not have a TZ
database installed.

This CL u...

Currently, FromDir identifies a VCS checkout directory just by checking
whether it contains a sp...

This is an oversight from https://go-review.googlesource.com/c/go/+/419875,
where script command...

Remove the useless issueSpill and continue directly.

Change-Id: I085e566be6f7200235e1bfe1f56a8e...

Per discussion with Roland Shoemaker, this updates
x509.CreateRevocationList to mirror the behav...

Change-Id: Ida7e756f01a2c115ac58bf10aa13b2f8fd57b6a1
GitHub-Last-Rev: 4694d397bd3ad488fd05ed2cc6...

Two edge cases that were mentioned in the docs are actually impossible:

* For NIST curves, EC...

In https://build.golang.org/log/d2eb315305bf3d513c490e7f85d56e9a016aacd2,
we observe a failure i...

The -C flag is like tar -C or make -C: it changes to the named directory
early in command startu...

Currently, with PGO, the inliner uses node weights to decide if a
function is inlineable (with a...

CC-BY-3.0 was shiny and new back in 2009, but CC-BY-4.0 is
generally preferred now. Update our C...

We don't have a formatter for these files, so check here that
they are in the right form to allo...

We were mishandling {{range $i = .}}, treating it as though it were
{{range $i := .}}. That happ...

net.IP states that a 16-byte slice can still be an IPv4 address.
But after netip.Addr is introdu...

Change-Id: I30783aa6a13ad8348fa24b27672d542a868f96de
GitHub-Last-Rev: c4584ad9dab9736275c2f2554a...

For #56041

Change-Id: I6c98458b5c0d3b3636a53ee04fc97221f3fd8bbc
Reviewed-on: https://go-review....

Randomized feature enable/disable might be something we use to
help users debug any problems wit...

Montgomery multiplication can be used for Exp mod even m
by splitting it into two steps - Exp mo...

Setting up for improving even modulus.

name time/op
ExpMont/Odd-16 2...

There does not seem to be any point to this sync.Once.
I noticed because I was surveying uses of...

Fuzz tests are meant to be run just like ordinary tests,
so copy the same loop cpu and count loo...

It adds support for no-reload option, as specified in resolv.conf(5):
no-reload (since glibc 2....

Fixes AIX build.

Change-Id: Icbb33896017bbcc488a8baff20e10eb0e14ea4b9
Reviewed-on: https://go-r...

The global ListOfHotCallSites set is used to communicate between
CanInline and InlineCalls the s...

This should reduce spurious VCS failures on slow builders, like the
one observed in
https://buil...

ErrWaitDelay is not expected to occur in this test, but if it does
it indicates a failure mode v...

I noticed some test failures in the build dashboard after CL 445597
that made me realize the gra...

We reused p so we were deleting the same directory twice instead of two
different directories. F...

Otherwise given a file like defs_nacl_amd64p32.go.~1~ we will add
"nacl" and "amd64p32" to AllTa...

The go1 benchmark suite does a lot of work at package init time, which
makes it take quite a whi...

The result of the call to fmt.Errorf was unused. It was clearly
intending to print the message, ...

If TestArenaCollision cannot reserve the address range it expects to
reserve, it currently fails...

Check for and reject environment variables containing NULs.

The conventions for passing environ...

Track the running tests and when they started,
so that we can report the running tests on a test...

Use a slightly different line number pragma when emitting instrumented
code, so as to ensure tha...

Change the 'PrepareForCoverageBuild' helper function to provide more
sensible defaults in the ca...

This patch fixes a typo/bug introduced in CL 441858 where when pattern
matching a coverage count...

When coverage testing a local package (defined by a relative import
path such as "./foo/bar") th...

Change the macOS implementation to use libc calls.
Using libc calls directly is what we do for a...

(Suggested by Austin in CL 445596.)

Change-Id: Ic774d551e8085d15435ef2b3c78d0169a365ce41
Review...

Also removes no-longer-needed "Any" field from compiler's DebugFlags.
Test/use case for this is ...

This an end-to-end test that sets GOROOT to a symlink
to the distribution, approximating copyin...

We kind of have this mechanism already, just normalizing it and
using it in a bunch of places. P...

Make them a separate type, so the normal sparse maps don't
need the extra storage.

Change-Id: I...

The recently added rule only works before decomposing slices.
Add a rule that works after decomp...

Since pgo is a new package, it is reasonably straightforward to
encapsulate its state into a non...

The test added in CL 446115 was failing on Plan 9, on which the error
returned by a failed open ...

Parts of package pgo fetch the line number of a node by parsing the
number out of the string ret...

For most tests, the test's deadline itself is more appropriate than an
arbitrary timeout layered...

This adds a testenv.CommandContext function, with timeout behavior
based on the existing logic i...

Make linkgetlineFromPos and getFileIndexAndLine methods on Link, and
give the former a more desc...

The most important change here is to log output from the child, making
it easier to diagnose pro...

The test sleeps for 1 millisecond to give the cancellation a moment
to take effect. This is flak...

Wasm can't handle the recusion for XML nested to depth 10,000.
Cut it off at 5,000 instead. This...

This one slipped through a previous cleanup
and showed up in an allocation profile.

Change-Id: ...

Change-Id: Ie3b4bfe483d7ef43da29ea1dd73d423dac36cf39
Reviewed-on: https://go-review.googlesource...

This may fix the android-.*-emu builders, which are currently broken.

For #47257.

Change-Id: I...