For #47694.
For #50954.

Change-Id: I3789e145d64025fe2bf787fa5d01a21832903586
Reviewed-on: https...

For #47694.
For #50912.
For #50937.

Change-Id: I3fae6c8dbbd61a45e669b8fb0c18ac76f2183963
Review...

This makes the error case pointed out in the issue like the current
message in Go 1.17 or -G=0 m...

When loading the corpus, if the cache contained an entry which was a
duplicate of an entry added...

Fixes #50945

Change-Id: Ib6251a5be09f4c6ba428ef4c97fe23ebffca3506
Reviewed-on: https://go-revie...

For #50646.
Fixes #50791.

Change-Id: I8fec25ae3f0280c5b5a778011d23842b886ba79e
Reviewed-on: htt...

We can type-check these fine but the API implications are unclear.

Fixes #50912.
For #50937.

C...

Fixes #50929.

Change-Id: I65b8eaf5e4b423839bc53c7b1db3679961498c8a
Reviewed-on: https://go-revi...

For #45713

Change-Id: Ia55a96702b99cccaf5d96c2125ee513700658444
Reviewed-on: https://go-review....

This reverts commit CL 358900.

Adding _TraceJumpStack to cgo traceback exposed a crashing condi...

Change-Id: I5cd980a7c825619cc782a3bca2a1c9c7971fdca2
GitHub-Last-Rev: 6833eedf2dab77f7263f980383...

- Use the correct predicate in Checker.implements: for interfaces
we cannot use the API Compar...

The configuration set by x/build/cmd/releasebot causes runtime/cgo to
be stale in the darwin/amd...

Fixes #48907

Change-Id: I504f846fc2ea655ba00aedb30f90847f938c347c
Reviewed-on: https://go-revie...

For #46784
For #47694
For #50685

Change-Id: I5351b56722d036a520d1a598ef7af95c5eb44c35
Reviewed-...

Fixes #50402

Change-Id: Ic539afc1aef3906ef591b403eba0fde20a5ccef2
Reviewed-on: https://go-revie...

For #45713
For #47694

Change-Id: I6f615c07749fca49c19f2ae22f79971c29aa8183
Reviewed-on: https:/...

This method is unused and was not discussed in the API
proposals. Note that all error output goe...

Where we provide it we take it from the Checker (which is already
passed in). Thus there's no ne...

Now that we have the detailed error reporting in Checker.implements
we don't need it anymore in ...

This CL copies (and adjusts as needed) the logic for error reporting
from operand.assignableTo t...

Change-Id: Ic338788d6410ed0d09ad129811377ee9ce5ed496
Reviewed-on: https://go-review.googlesource...

This patch reworks the handling of the DWARF DW_AT_bit_offset and
DW_AT_data_bit_offset attribut...

Change-Id: Ia324c6185e36efd4ea7dc92d7c2233fec8f5a55f
Reviewed-on: https://go-review.googlesource...

Credit to rsc@ for the original patch.

Thanks to the OSS-Fuzz project for discovering this
issu...

Interface method receivers are synthetic: they record either the
interface type or the the defin...

For a composite literal expression like []T{{f: 1}}, we allow T to be
a pointer to struct type, ...

These can go wrong when one of the operands is the minimum integer value.

Fixes #50854.

Change...

Adds an addCorpusEntry method to coordinator which manages checking for
duplicate entries, writi...

Add a missing shape check in (*Tsubster).tinter when substituting on a
generic type which is an ...

This CL updates unified IR to look at the structural type of a
composite literal type, rather th...

This reverts CL 380854.

Per the conluding discussions on #50791. A follow-up will
document `com...

Follow-up on CL 380754.

For #50791.

Change-Id: Ia2f8f9785c2f02647525e7ee4168991fd4066dd3
Revie...

For #50791.

Change-Id: Ib12009d2895146e55ec3a51aa8ceafe58dfd82a5
Reviewed-on: https://go-review...

It was already noted in text/template; copied from there.

Change-Id: Ie749d04004af60f2333073ddf...

This method isn't available in go/types, and its use by unified IR is
non-essential. This CL ref...

'go list' has its own internal parallelism, so invoking in in parallel
can produce up to quadrat...

For #50791.

Change-Id: I7f135bb6626128a3cee9fd71c57535c1fc83ac7f
Reviewed-on: https://go-review...

Use "hgdate" since the strftime filter is unsupported by Mercurial under
Windows.

Fixes #49841
...

C archives for packages in GOROOT are shipped along with binary
releases of the Go toolchain. Al...

The test previously checked that the DWARF DW_AT_comp_dir attribute
matched GOROOT_FINAL. Howeve...

Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercuri...

For #50183

Change-Id: Ie384333fb7a69d0d2cfaba0cfc4eb7afba2fd745
Reviewed-on: https://go-review....

Update the vendored x/tools to pick up CL 380014, which updates the
ifaceassert vet analyzer to ...

For #50646.

Change-Id: I7420545556e0df2659836364a62ce2c32ad7a8b1
Reviewed-on: https://go-review...

Method signatures can introduce a significant number of edges into the
type graph. One can imagi...

We have disallowed having a typeparam on the right-hand-side of a type
declaration. So, we disab...

Added a new absdiff2.go test case, which works fully without using a
typeparam on the right-hand...

While checking comparability of type parameters, we recurse through
_TypeSet.IsComparable, but d...

By processing non-alias type declarations before alias type declaration,
and those before everyt...

The type checker doesn't have a general mechanism to "use" the type
of a type alias whose type d...

Change-Id: I48804eba94ec455c4764d52af148f4210faf7d94
Reviewed-on: https://go-review.googlesource...

In validType, when we see an instantiated type, proceed as with
non-generic types but provide an...

This is necessary for cycle detection over imported types whose
underlying types are set by impo...

Because validType doesn't modify global state anymore, there's
no need to ignore imported types....

Now that we have a separate top-level entry point for validType
we can use the more narrow type ...

With this change validType doesn't modify global state anymore.
It also eliminates the need for ...

The validType check is independent of the work of declaring objects.
Move it into a separate fil...

Change-Id: I40cfc87731d3a29670a3e183948898ea0cb2402d
Reviewed-on: https://go-review.googlesource...

Change-Id: Idc4d561c7037f33aa9c844b411c38c6cb5bbfbcd
Reviewed-on: https://go-review.googlesource...

TestFutexsleep was originally created in CL 7876043 as a
regression test for buggy division logi...

Given we have support for field access to type params with a single
structural type, we need to ...

Add some useful comments, mainly relates to types.Type. (No non-comment
changes.)

Change-Id: I3...

Very, very rarely TestVectoredHandlerDontCrashOnLibrary fails because
the C subprocess exits wit...

This reverts CL 380057.

Reason for revert: appears to have broken x/tools tests on macOS.

Chan...

Mostly from CL 367954.

Change-Id: Id003b0f785a286a1a649e4d6e8c87d0418a36545
Reviewed-on: https:...

This fixes checks for crossing module boundaries when the root of
the module is a symlink. We're...

The closure in parallelLabelHog should be labeled in a addition to
parallelLabelHog itself. Gene...

This reverts CL 376414.

For #47694.
For #50481.

Change-Id: Ie73961046e52e6e5d3262ef0aeaa24bec7...

In a method declaration "func (f *Foo[_, _]) String() string { ... }",
the two blank typeparams ...

Use an enviroment variable rather than a build tag to control starting
a busy loop thread when t...

And disallow replaces of any main modules in the go.work file itself.

Change-Id: Ifa9ba9eaed047...

Fixes #50705.

Change-Id: I85857f836cbe58447625df6cd56756d3a69880ff
Reviewed-on: https://go-revi...

Now that we instantiate methods on instantiated types, there is no need
to use unification to ma...

This is a map from identifiers to type parameters, use *TypeParam
as map value instead of Type.
...

Change-Id: I23264972329aa3414067cd0e0986b69bb39bbeb5
GitHub-Last-Rev: d1d668a3cbe852d9a06f03369e...

Fixes #49687

Change-Id: Ife7f64f4c98449eaff7327e09bc1fb67acee72c9
Reviewed-on: https://go-revie...

Most CONVIFACEs are created in the transform phase (or old typechecker,
in -G=0 mode). But if th...

Slightly better for cases such as string(1 << s).
Leaves type-checker tests alone for now becaus...

It was removed in CL 378576.

For #50501

Change-Id: I26b8f0e99a40fa5c616aa4849a6ab15dd0d072f8
R...

TestCPUProfileMultithreadMagnitude compares pprof results vs OS rusage
to verify that pprof is c...

Document and enforce API expectation. Add a test so we don't
inadvertently change the function b...

This makes TestLabelSystemstack much more strict, enabling it to detect
any misplacement of labe...

GC background mark worker goroutines are created when the first GC is
triggered (or next GC afte...

Instead, allow the test to run up until nearly the test's deadline,
whatever that may be, and th...

For an extension operation like MOWWreg, if the operand is already
extended, we optimize the sec...

This test occasionally takes very slightly longer than the 3 second
timeout on slow builders (es...

This test was missed in CL 358539, presumably because the 'longtest'
builders lack a 'gpg' execu...

Fixes #45114.

Change-Id: I969e5f1037254fc0ffbba2fc07a81a3987e6b05f
Reviewed-on: https://go-revi...

For #45114.
Fixes #45117.

Change-Id: I71d6650ae2c4c06952fce19959120f15f13c08a2
Reviewed-on: htt...

Fixes #49541.

Change-Id: I27a52d0722a7408758682e7ddcd608c0a6c4881b
Reviewed-on: https://go-revi...

Also, simplify one expression (missed comment on previous review).

Change-Id: Ic2d212442c2738e0...

Currently the code handles the case of returning values from
a function with no result parameter...

Updates #47738
Fixes #49598

Change-Id: I708dcb880a701699116227a9eaca994cf460fef9
Reviewed-on: h...

Consider the following program:

package p

func f() {
x := 1
v := 2
switch v.(type) {
...

This extends the skip added in CL 375635 to the "_Headers" variant of
the test, since we have ob...

In the compiler, we need to distinguish field and method access on a
type param. For field acces...

Fixes #50501
(in a sense, by removing a flag that looks like it should do something
it does not)...

We use uname -m to decide the GOHOSTARCH default,
and on my ARM64 Mac laptop, uname -m prints x8...

The VMOVQ instruction stores a 128-bit number into a V register, for
example:
VMOVQ $0x11223...